Uploaded image for project: '[Read Only] - Hippo Site Toolkit 2'
  1. [Read Only] - Hippo Site Toolkit 2
  2. HSTTWO-4593

Content beans test setup results in circular dependencies

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 13.3.0
    • Component/s: None
    • Labels:
      None
    • Similar issues:
    • Processed by team:
      Pulsar
    • Sprint:
      Platform 208 13.2+Maint+SSO

      Description

      for the tests of the runtime hst content beans, the content type service is used. The content type service expects a repository test fixture below

      hippo:namespaces
      

      For this reason, the HST content beans module pulls in

          <dependency>
            <groupId>org.onehippo.cms7</groupId>
            <artifactId>hippo-package-cms-dependencies</artifactId>
            <version>${hippo.packages.version}</version>
            <type>pom</type>
            <scope>test</scope>
          </dependency>
      

      However, 'hippo-package-cms-dependencies' is a downstream project of the HST! This is not allowed.

      I will look into moving the

      hippo:namespaces
      

      fixture from cms project to the repository testutils, since the hippo:namespaces is really a primary citizen of our setup and thus can better always be present.

      Note that the same problem resulted in CMS-11632 which should be fixed in CMS-11633

      Besides that, the HST content beans now pull in

          <dependency>
            <groupId>org.onehippo.cms7</groupId>
            <artifactId>hippo-plugin-selections-addon-repository</artifactId>
            <version>${hippo.plugin.selections.version}</version>
            <scope>test</scope>
          </dependency>
      
          <dependency>
            <groupId>org.onehippo.cms7</groupId>
            <artifactId>hippo-plugin-gallerypicker</artifactId>
            <version>${hippo.plugin.gallerypicker.version}</version>
            <scope>test</scope>
          </dependency>
      

      These are really downstream projects of the HST and are not allowed to be pulled in by the HST. The integration tests requiring those should move the the selections and gallerypicker projects

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                aschrijvers Ard Schrijvers
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: