Uploaded image for project: 'Hippo CMS'
  1. Hippo CMS
  2. CMS-10596

Cutomizability in org.hippoecm.frontend.util.RequestUtils#getRemoteAddrs()

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: 4.1.0
    • Fix Version/s: 4.2.0
    • Component/s: None
    • Labels:
      None
    • Similar issues:

      Description

      At the moment, org.hippoecm.frontend.util.RequestUtils#getRemoteAddrs() checks only X-Forwarded-For header values.
      This makes it very difficult to test out GEO IP based logic (such as hippo relevance GeoIPCollector) in non-production environment if there are multiple reverse proxy servers. If you want to fix it in Infrastructure level, then you end up with a lot of complex settings such as IP whitelisting, public/private server considerations such SEO perspective, security, etc, etc, causing a lot of inter-dependencies between multiple parties unnecessarily.
      This is not so convenient in testing/validation in non-production environment.
      So, I'd like to suggest an improvement in org.hippoecm.frontend.util.RequestUtils#getRemoteAddrs() to be able to inject some custom logic (e.g, different header value) in projects if needed.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                wko Woonsan Ko
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: