Details
-
Improvement
-
Status: Closed
-
Normal
-
Resolution: Fixed
-
4.1.0
-
None
-
None
Description
At the moment, org.hippoecm.frontend.util.RequestUtils#getRemoteAddrs() checks only X-Forwarded-For header values.
This makes it very difficult to test out GEO IP based logic (such as hippo relevance GeoIPCollector) in non-production environment if there are multiple reverse proxy servers. If you want to fix it in Infrastructure level, then you end up with a lot of complex settings such as IP whitelisting, public/private server considerations such SEO perspective, security, etc, etc, causing a lot of inter-dependencies between multiple parties unnecessarily.
This is not so convenient in testing/validation in non-production environment.
So, I'd like to suggest an improvement in org.hippoecm.frontend.util.RequestUtils#getRemoteAddrs() to be able to inject some custom logic (e.g, different header value) in projects if needed.
Attachments
Issue Links
- causes
-
CMS-10621 Fix unit test added with CMS-10596
- Closed
- relates to
-
HSTTWO-3912 Cutomizability in HstRequestUtils#getRemoteAddrs()
- Closed
-
CMS-11029 Support multiple header names in http-forwarded-for-header context init parameter
- Closed