Uploaded image for project: 'Hippo CMS'
  1. Hippo CMS
  2. CMS-11029

Support multiple header names in http-forwarded-for-header context init parameter

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.2.0
    • Component/s: None
    • Labels:
      None
    • Similar issues:

      Description

      We do have a good extension point by setting a context init parameter like the following example, in order to override the default reverse proxy X-Forwarded-For header name, as of CMS-10596:

      <Parameter name="http-forwarded-for-header" value="X-FOO-Forwarded-For" override="false"/>

      I'd like to propose an improvement that allows a comma-separated header names to allow multiple header names. e.g, "X-FOO-Forwarded-For, X-Forwarded-For".

      The main reason is, sometimes developers want to test it with a different header name (e.g, "X-FOO-Forwarded-For") than the header name ("X-Forwarded-For") used by the load balancer. Load balancers tend to overwrite the header regardless of whether or not it's set by client. So, by having this multiplicity support, it can be easier for developers inside a corporate proxy network to test it out with different client ip addresses by using a different header name option.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                wko Woonsan Ko
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: