Uploaded image for project: '[Read Only] - Hippo Site Toolkit 2'
  1. [Read Only] - Hippo Site Toolkit 2
  2. HSTTWO-3912

Cutomizability in HstRequestUtils#getRemoteAddrs()

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Top
    • Resolution: Fixed
    • 4.1.1
    • 4.2.0
    • None

    Description

      At the moment, HstRequestUtils#getRemoteAddrs() checks only X-Forwarded-For header values.
      This makes it very difficult to test out GEO IP based logic (such as hippo relevance GeoIPCollector) in non-production environment if there are multiple reverse proxy servers. If you want to fix it in Infrastructure level, then you end up with a lot of complex settings such as IP whitelisting, public/private server considerations such SEO perspective, security, etc, etc, causing a lot of inter-dependencies between multiple parties unnecessarily.
      This is not so convenient in testing/validation in non-production environment.
      So, I'd like to suggest an improvement in HstRequestUtils#getRemoteAddrs() to be able to inject some custom logic (e.g, different header value) in projects if needed.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              wko Woonsan Ko (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: