Uploaded image for project: '[Read Only] - Hippo Repository'
  1. [Read Only] - Hippo Repository
  2. REPO-1694

revisit delta logic in case incoming config and jcr contain an item, but the baseline does not

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Normal
    • Resolution: Fixed
    • None
    • 5.0.0
    • None
    • None
    • Platform Sprint 157: Finish, Platform Sprint 158: Hardening

    Description

      While testing HCM-88, we found that most nodes get reported as "override" when re-applying the configuration. The code that logs these overrides is in ConfigurationConfigService:

                      if (baselineChild == null) {
                          // node should not yet exist, but actually does; one edge case in which is ok and no message needs
                          // to be logged is if the node is autoCreated and its parent was also just created
                          if (!(existingChildNode.getDefinition().isAutoCreated() && existingChildNode.getParent().isNew())) {
                              final String msg = String.format("[OVERRIDE] Node '%s' has been added, " +
                                              "but will be re-created due to the incoming definition %s.",
                                      updateChild.getPath(), updateChild.getOrigin());
                              logger.info(msg);
                          }
      
                          final String childPrimaryType = existingChildNode.getPrimaryNodeType().getName();
                          baselineChild = newChildOfType(childPrimaryType);
                      }
      

      Attachments

        Activity

          People

            Unassigned Unassigned
            oscholten Oscar Scholten (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: