Uploaded image for project: '[Read Only] - Hippo Site Toolkit 2'
  1. [Read Only] - Hippo Site Toolkit 2
  2. HSTTWO-4191

Postpone initializing the HST Component Manager until the RepositoryService is available

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Normal
    • Resolution: Fixed
    • None
    • 5.2.0
    • None
    • None

    Description

      Currently, the HST component mngr starts up possibly before the repository is running: This depends on whether first the hst or first the cms webapp starts.

      This means that all HST spring beans have to be constructed such that repository access is always lazy. A typical construct then is for example instead of that a Spring bean during initialization can direct get hold of, say, the repository LockManager, it does so by for example using a supplier, where the supplier might look something like:

       @Override
    public LockManager get() {
        if (lockManager != null) {
            return lockManager;
        }
        synchronized (lock) {
            if (lockManager != null) {
                return lockManager;
            }
            while ((lockManager = HippoServiceRegistry.getService(LockManager.class)) == null) {
                log.debug("{} not available yet, waiting {} {} before reattempting to get it", LockManager.class.getSimpleName(), waitMillis, MILLISECONDS);
                try {
                    MILLISECONDS.sleep(waitMillis);
                } catch (InterruptedException e) {
                    log.info("Interrupted while waiting for {}", LockManager.class.getSimpleName());
                    Thread.currentThread().interrupt();
                }
            }
        }
        return lockManager;
    }

      This is very unhandy. Starting up the HST Spring component manager after the repository service has become available results in that we can get rid of these kind of supplier patterns or separate threads trying until something works (like registering a jcr observer)

      The fix is simple AFAICS: Postpone the HST component manager creation until the repository is available.

      Only tricky part might be integration tests, where the repository initialization is triggered by a spring bean. However I think this shouldn't be that hard to fix if it turns out to be a problem.

      Attachments

        Issue Links

          blocks

          Improvement - An improvement or enhancement to an existing feature or task. HSTTWO-4199 Create a PingFilter variant to the HST PingServlet

          • Normal - Normal priority, tasks to be done before next intermediate release
          • Closed
          is awaited by

          Improvement - An improvement or enhancement to an existing feature or task. HSTTWO-4165 Better support for checking site availability

          • Normal - Normal priority, tasks to be done before next intermediate release
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. HSTTWO-4198 Initialize the loading of all HST configuration nodes without http request

          • Normal - Normal priority, tasks to be done before next intermediate release
          • Closed
          is cloned by

          Improvement - An improvement or enhancement to an existing feature or task. HSTTWO-4324 Backport 11.2 - Postpone initializing the HST Component Manager until the RepositoryService is available

          • Normal - Normal priority, tasks to be done before next intermediate release
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. HSTTWO-4325 Backport 10.2 - Postpone initializing the HST Component Manager until the RepositoryService is available

          • Normal - Normal priority, tasks to be done before next intermediate release
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. HSTTWO-4328 Backport 11.2 - Postpone initializing the HST Component Manager until the RepositoryService is available

          • Normal - Normal priority, tasks to be done before next intermediate release
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. HSTTWO-4329 backport 10.2 - Postpone initializing the HST Component Manager until the RepositoryService is available

          • Normal - Normal priority, tasks to be done before next intermediate release
          • Closed
          relates to

          Improvement - An improvement or enhancement to an existing feature or task. HSTTWO-3472 Support HST Container Loading (currently done by HstSiteConfigServlet) in earlier phase for more accessibility

          • Normal - Normal priority, tasks to be done before next intermediate release
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. HSTTWO-4200 Support better graceful destroy of the HST Spring component manager

          • Normal - Normal priority, tasks to be done before next intermediate release
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. CMS-12905 Support setting the root spring app context as parent of the HST spring context

          • Normal - Normal priority, tasks to be done before next intermediate release
          • Open

          Activity

            People

              Unassigned Unassigned
              aschrijvers Ard Schrijvers
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: