Uploaded image for project: 'Hippo CMS'
  1. Hippo CMS
  2. CMS-11405

Console: fix styling of dialog buttons

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 13.2.0
    • Component/s: console
    • Labels:
      None
    • Similar issues:
    • Story Points:
      2
    • Processed by team:
      Tiger
    • Sprint:
      Tiger Sprint 204

      Description

      The dialogs the console still extend from AbstractDialog. This dialog uses the native browser buttons. In the current Chrome these buttons appear now very small.

      Solution: extend from Dialog instead.

      Dialog also provides some sugar for common use cases like setting the dialog size and title:

      • instead of overridding¬†AbstractDialog#getProperties to return a ValueMap with width&height key-value pairs,¬†call Dialog#setSize(DialogContants.MEDIUM_AUTO) in the constructor (see DialogConstants for all available OOTB sizes)
      • instead of overriding AbstractDialog#getTitle, call Dialog#setTitle

      In addition, Dialog has a bottom-left-slot that displays an EmptyPanel by default but can be used to, for example, display a bread-crumb widget (see AbstractBrowserDialog line 78) or a date-picker (see SchedulePublishDialog line 64).

        Attachments

        1. console dialog buttons appear small in chrome.png
          26 kB
          Bert Leunis
        2. dialog with error.png
          33 kB
          Bert Leunis
        3. new style for dialog.png
          25 kB
          Bert Leunis

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                bleunis Bert Leunis (Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: