Uploaded image for project: '[Read Only] - Hippo Plugins'
  1. [Read Only] - Hippo Plugins
  2. HIPPLUG-1551

Taxonomy: Fix styling of dialog buttons

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Low
    • Resolution: Fixed
    • None
    • 13.1.0
    • plugins-taxonomy

    Description

      The dialogs in this plugin extend from AbstractDialog. This dialog uses the native browser buttons. In the current Chrome these buttons appear now very small.

      Solution: extend from Dialog instead.

      Dialog also provides some sugar for common use cases like setting the dialog size and title:

      • instead of overridding¬†AbstractDialog#getProperties to return a ValueMap with width&height key-value pairs, call Dialog#setSize(DialogContants.MEDIUM_AUTO) in the constructor (see DialogConstants for all available OOTB sizes)
      • instead of overriding AbstractDialog#getTitle, call Dialog#setTitle

      In addition, Dialog has a bottom-left-slot that displays an EmptyPanel by default but can be used to, for example, display a bread-crumb widget (see AbstractBrowserDialog line 78) or a date-picker (see

      SchedulePublishDialog line 64).

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              bleunis Bert Leunis (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: