Uploaded image for project: '[Read Only] - Hippo Repository'
  1. [Read Only] - Hippo Repository
  2. REPO-918

TranslationWorkflowImpl still requires (deprecated) FullReviewedActionsWorkflow to be invoked on document level



    • Bug
    • Status: Closed
    • High
    • Resolution: Fixed
    • None
    • 2.26.00
    • None


      With the introduction of the DocumentWorkflow, replacing the now deprecated *ReviewedActionsWorkflow(s), all usages of these deprecated workflows should be replaced.
      However, currently this is not yet possible for the TranslationsWorkflow which uses and depends on a CopyWorkflow implementation (in casu the FullReviewedActionsWorkflow) for documents of node type hippostdpubwf:document.
      The problem is that the TranslationsWorkflow uses/expects a fallback CopyWorkflow handling for other node types (e.g. assets) which is provided through the DefaultWorkflow.

      The DefaultWorkflow however expects to be invoked on document node, not handle node, like the DocumentWorkflow. So we now have a workflow type 'mismatch' between these two, both implementing the CopyWorkflow but requiring different instantiation (document vs handle).

      The probably best and proper solution is to also convert/upgrade the DefaultWorkflow to become handle based, like the DocumentWorkflow.
      This should be a much easier change than the DocumentWorkflow but nonetheless will require changes in all its current usages.
      And, like for the DocumentWorkflow, we should provide a bc layer to support existing usages without breakage.

      Preferrably, we should do in the same release as the DocumentWorkflow, such that we can properly resolve and remove these bc deprecated layers all at the same time.




            jsheriff Junaidh Kadhar Sheriff
            adouma Ate Douma
            0 Vote for this issue
            3 Start watching this issue