Uploaded image for project: '[Read Only] - Hippo Repository'
  1. [Read Only] - Hippo Repository
  2. REPO-483

Remove locking code from workflow manager

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.24.00
    • Component/s: None
    • Labels:
      None
    • Similar issues:

      Description

      The workflow manager got some complicated locking code in REPO-224, that supposedly should have fixed concurrent workflow operations on the same document.
      The document model relies on the documents having the same name as the handle. Combining renaming with e.g. editing can then lead to problems in this document model.

      However, the implemented solution was to add the 'mix:lockable' mixin to the hippo:hardhandle and always do locking when doing workflow. This last change has been reverted, so no actual locking is being done. The code to do this is all still there. So it is quite dead and upon a closer look contains bugs (instead of unlocking, it locks again in the finally block...).

      My proposal is to remove this locking code.

        Attachments

          Activity

            People

            • Assignee:
              fvlankvelt Frank van Lankvelt (Inactive)
              Reporter:
              fvlankvelt Frank van Lankvelt (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: