Uploaded image for project: '[Read Only] - Hippo Repository'
  1. [Read Only] - Hippo Repository
  2. REPO-2292

PostMigrators are always triggered in case of AutoExportService is enabled

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Normal
    • Resolution: Fixed
    • 14.0.0, 13.4.0, 13.4.1
    • 14.1.0
    • None
    • None
    • Platform 222 - 14.0 Hangover

    Description

      There is a specific AutoExportService status check in ConfigurationServiceImpl when running migrators. Enabling or disabling AutoExportService doesn't have anything to do with migrators eventually this check should be removed.

       

          private boolean shouldSkipBecauseOfDigestMatch(final ConfigurationModelImpl bootstrapModel,
                                                         final ConfigurationModelImpl baselineModel,
                                                         final String siteName)
                  throws RepositoryException {
              // NOTE: This will not notice differences within content files, since these are not fully stored
              //       in the baseline. This will only notice added or removed content files, changed actions,
              //       or changed config files.
              // TODO v13.3: do this check based on the stored JCR property, before spending time loading the baseline,
              //       once we include webfile bundle digests in the main model digest
      
              StopWatch stopWatch = new StopWatch();
              stopWatch.start();
      
              boolean skip = !fullConfigure && !startAutoExportService
                      && bootstrapModel.currentSitesMatchByDigests(baselineModel);
      
              // check the webfiles bundle digests here, too!
              if (skip) {
                  try {
                      final List<WebFileBundleDefinitionImpl> webFileBundleDefs =
                              (siteName != null)?
                                      getWebFileBundleDefsForSite(bootstrapModel, siteName):
                                      bootstrapModel.getWebFileBundleDefinitions();
                      skip = configService.shouldSkipWebfilesBecauseOfDigestMatch(webFileBundleDefs, baselineService, session);
                  }
                  catch (IOException e) {
                      throw new RepositoryException("Exception checking webfiles bundle digests during bootstrap", e);
                  }
              }
      
              stopWatch.stop();
              log.debug("digest comparison in {}", stopWatch.toString());
      
              return skip;
          }
      

      Attachments

        Activity

          People

            Unassigned Unassigned
            ekarakus Erdem Karakus
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: