Uploaded image for project: '[Read Only] - Hippo Repository'
  1. [Read Only] - Hippo Repository
  2. REPO-2164

Brittle error handling flow in ConfigurationService bootstrap process

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Normal
    • Resolution: Fixed
    • 13.0.0, 12.6.0
    • 14.0.0, 13.4.1
    • None
    • None
    • Platform 220 - Hardening, Platform 221 - 14.0 CodeFreeze

    Description

      I encountered two different problems related to incorrect or unexpected flow of error handling within the ConfigurationServiceImpl bootstrap process:

      1. witin init() the runtimeConfigurationModel only gets initialized (not null) after successful applying the bootstrapModel
        For a non-first bootstrap (e.g. a baselineModel already exists) it might be better/acceptable to use it as initial/fallback runtimeConfigurationModel instead. Or otherwise the current NPEs described below need to be fixed/prevented.
        If currently the apply bootstrapModel fails (for example because of an error loading an cnd) and the runtimeConfigurationModel remains null, it causes NPEs later on:
        1. within AutoExportServiceImpl which is started regardless the success state (IMO it shouldn't be started if there are any errors before)
        2. completely broken Console where for each node/property the runtimeConfigurationModel is access to retrieve and render their origin (within the NodeEditor and PropertiesEditor classes)
      2. Within applySiteConfig() if applyContent() fails, webfiles also no longer are loaded. Which IMO can and should be treated independently.

      Attachments

        Activity

          People

            Unassigned Unassigned
            adouma Ate Douma (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: