Uploaded image for project: 'Hippo Repository'
  1. Hippo Repository
  2. REPO-1886

Some LockManager unit tests and integration tests possibly don't correctly report failures

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: High
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.1.0, 5.0.3
    • Labels:
      None
    • Similar issues:
    • Epic Link:
    • Processed by team:
      Turing
    • Sprint:
      Turing Sprint 169

      Description

      A couple of tests have the following pattern:

       @Test
          public void assert_something() throws Exception {
              Thread lockThread = new Thread(() -> {
                  fail("I failed");
              });
              lockThread.start();
              lockThread.join();
          }
      

      The problem with this pattern is that although something gets logged like

      Exception in thread "Thread-2" java.lang.AssertionError: I failed
      

      the test itself just passes because the Thread the runs the test didn't get the exception

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                aschrijvers Ard Schrijvers
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: