Uploaded image for project: 'Hippo Repository'
  1. Hippo Repository
  2. REPO-1807

Refactor DefinitionMergeService to move repeated params to fields

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.0.1
    • Labels:
      None
    • Similar issues:
    • Epic Link:
    • Processed by team:
      Platform
    • Sprint:
      Platform164

      Description

      The params toExport and model aka: baseline are repeated in most of the methods of DefinitionMergeService, and they don't change after the first block of init logic in mergChangsToModules(). These should be computed in the constructor and made available as fields instead of params to simplify the code.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              PCentgraf Peter Centgraf
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: