Uploaded image for project: '[Read Only] - Hippo Repository'
  1. [Read Only] - Hippo Repository
  2. REPO-1790

EventJournalProcessor or DefinitionMergeService must implement mechanism to reset runtime configuration model

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Normal
    • Resolution: Fixed
    • None
    • 5.0.1
    • None
    • None
    • 1
    • Platform162: Pre-GA2, Platform163: GA!, Platform164

    Description

      Currently, EventJournalProcessor gets the current runtime configuration model as one of the first instructions in EventJournalProcessor#processEvents:

      this.currentModel = configurationService.getRuntimeConfigurationModel();
      

      This currentModel is passed into DefinitionMergeService, which modifies that model in for instance DefinitionMergeService#mergeConfigDefinitionNode:

      new ConfigurationTreeBuilder(model.getConfigurationRootNode())
          .markNodeAsDeletedBy(incomingConfigNode, 
          deleteDef).pruneDeletedItems(incomingConfigNode);
      

      The problem is that in case of exceptions in DefinitionMergeService the changes in the model are not reset.

      While fixing this, also look into the following code in EventJournalProcessor#checkAddEventPath:

      final ConfigurationItemCategory category = autoExportConfig.getCategoryForItem(eventPath, propertyPath,
          configurationService.getRuntimeConfigurationModel());
      

      Attachments

        Activity

          People

            Unassigned Unassigned
            oscholten Oscar Scholten (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: