Uploaded image for project: '[Read Only] - Hippo Site Toolkit 2'
  1. [Read Only] - Hippo Site Toolkit 2
  2. HSTTWO-4650

ObjectConverterImpl doesn't log frozen node path

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Normal
    • Resolution: Fixed
    • 13.4.0, 14.0.0
    • 5.6.8, 13.4.1, 14.0.0
    • None
    • None
    • Platform 220 - Hardening

    Description

      In the method

      org.hippoecm.hst.content.beans.manager.ObjectConverterImpl#getActualNode(final Node node)
      
       protected Node getActualNode(final Node node) throws RepositoryException {
              if (node instanceof HippoBeanFrozenNode) {
                  return node;
              }
      
              if (node.isNodeType(NT_FROZEN_NODE)) {
                  log.error("Unexpected {} node since we always expect a decorated node of type '{}'", NT_FROZEN_NODE,
                          HippoBeanFrozenNode.class.getName(), new Exception(String.format("Unexpected frozen node for '{}'", node.getPath())));
                  return HippoBeanFrozenNodeUtils.getWorkspaceFrozenNode(node, node.getPath(), node.getName());
              }
      
      

      In this snippet, the String.format doesn't place the value of the parameter node.path because the placeholder is "{}" but should be "%s"

      Attachments

        Activity

          People

            Unassigned Unassigned
            smuco Saimir Muco (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: