Uploaded image for project: 'Hippo Site Toolkit 2'
  1. Hippo Site Toolkit 2
  2. HSTTWO-4562

Forward recursion protection

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 13.1.1, 13.2.0
    • Component/s: None
    • Labels:
      None
    • Similar issues:
    • Processed by team:
      Platform
    • Sprint:
      Platform 206 - Content Beans 3

      Description

      The hst supports internal forwarding, see [1]

      However, a forward can trigger the very same resolved sitemap item as the one that triggered the forward leading to recursion.

      Thus for example we go from

      homepage -> pagenotfound -> pagenotfound -> pagenotfound -> pagenotfound

      For this, we should add simple short circuiting.

      Note that I do not tend to currently prevent this kind of recursion since that is quite unlikely to happen and should be avoided in end project code to happen (since end projects trigger the forward typically)

      homepage -> pagenotfound -> homepage ->pagenotfound -> homepage -> pagenotfound

      During the endless recursion, also the hst session pool will exhaust since every forward takes a new session from the pool : This is because at the beginning of the pipeline processing, the InitializationValve reset the jcr session in the request context to null and only at the very end of the request, all jcr sessions are returned to the session pool (which is after all the recursions happened)

      [1] https://documentation.bloomreach.com/library/concepts/error-pages-and-error-handling/3.-simple-exception-handling.html

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                aschrijvers Ard Schrijvers
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: