Details
-
Improvement
-
Status: Closed
-
Normal
-
Resolution: Fixed
-
None
-
None
-
None
Description
1) Why do we ignore the org.hippoecm.hst.core.sitemenu.CommonMenuItem#getProperties via org.hippoecm.hst.content.beans.support.jackson.CommonMenuItemMixin#getProperties? Isn't is useful to expose the properties?
2)
In HippoBeanMixin why do we ignore:
@JsonIgnore public String getPath();
isn't the path something to expose? I am ok with ignoring it by I am not sure
also we now have
@JsonIgnore public Map<String, Object> getProperties();
If we'd expose this, then every property gets exposed by default. This means of course there is redundancy because for example #getTitle would also be exposed as a seperate property (for example as myproject:title in the #getProperties map). However if there is no custom HST Bean for a document type (for example for a newsdocument), and it fall back to a HippoDocumentBean, then it would be nice if we expose #getProperties() : This makes the json response also workable without explicit hst content beans and a customer could opt for only using HippoDocumentBean without custom bean implementations.
3) Why are org.hippoecm.hst.content.beans.support.jackson.HippoBeanMixin#isHippoDocumentBean and org.hippoecm.hst.content.beans.support.jackson.HippoBeanMixin#isHippoFolderBean ignored?
4) Why is the org.hippoecm.hst.content.beans.support.jackson.HippoFolderBeanMixin#getLocale ignored? Can't the Locale be serialized as json?
5) Why are org.hippoecm.hst.content.beans.support.jackson.HippoGalleryImageSetBeanMixin#getThumbnail and org.hippoecm.hst.content.beans.support.jackson.HippoGalleryImageSetBeanMixin#getOriginal ignored? They make sense to expose for an imageset I'd think
6) For HippoMirrorBeanMixin, why is the public HippoBean getReferencedBean() ignored? Is this to avoid possible circular references? AFAICS this means that linked beans won't be displayed at all. Shouldn't we at least expose the 'id' of the linked bean and possibly the Link objects for that bean? (like the _self link and such)
Attachments
Issue Links
- relates to
-
HSTTWO-4227 [SPA++] Replace GREB API based Page Model pipeline by HST PageModelPipeline
- Closed