Uploaded image for project: '[Read Only] - Hippo Site Toolkit 2'
  1. [Read Only] - Hippo Site Toolkit 2
  2. HSTTWO-3701

HST Link Tag removes scheme when path is set to http(s)://...

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Normal
    • Resolution: Fixed
    • 3.2.0
    • 4.0.0
    • None
    • None
    • Platform Sprint 132

    Description

      If you (mis)use <hst:link> tag with absolute URL path attribute, it removes the scheme part only.
      For example,

      <hst:link path="https://www.example.com/index.html" />

      renders /www.example.com/index.html (note only 'https:/' part removed) since 10.

      It used to return the path attribute value without changing any before until 7.9

      -----------

      I think this is kind of regression by HSTTWO-3423. I saw this commit related to this:

      commit 0b2161228e85935390605012eee9242380ac007f

HSTTWO-3423 When the pathInfo is used from the HstLinkTag, then while the pathInfo starts with http:, https: or // , the pathInfo should strip off those prefixes: We do not allow those.

      But I think it should have returned the original path value without having to strip any forbidden prefixes (e.g, https: ), giving a warning optionally, without breaking any old behavior until 7.9.

      Attachments

        Issue Links

          is a result of

          Bug - A problem which impairs or prevents the functions of the product. HSTTWO-3423 Align path info encoding with rest of URL encoding

          • Normal - Normal priority, tasks to be done before next intermediate release
          • Closed
          is cloned by

          Bug - A problem which impairs or prevents the functions of the product. HSTTWO-3702 [Backport 3.2] HST Link Tag removes scheme when path is set to http(s)://...

          • Normal - Normal priority, tasks to be done before next intermediate release
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. HSTTWO-3703 [Backport 3.1] HST Link Tag removes scheme when path is set to http(s)://...

          • Normal - Normal priority, tasks to be done before next intermediate release
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. HSTTWO-3704 [Backport 7.9] HST Link Tag removes scheme when path is set to http(s)://...

          • Normal - Normal priority, tasks to be done before next intermediate release
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. HSTTWO-3705 [Backport 7.8] HST Link Tag removes scheme when path is set to http(s)://...

          • Normal - Normal priority, tasks to be done before next intermediate release
          • Closed

          Activity

            People

              Unassigned Unassigned
              wko Woonsan Ko (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: