Uploaded image for project: 'Hippo Site Toolkit 2'
  1. Hippo Site Toolkit 2
  2. HSTTWO-3299

Guard the HstFreeMarkerServlet initialization against heavy initial concurrent usage

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: 2.28.10
    • Fix Version/s: 2.28.11
    • Component/s: None
    • Labels:
    • Similar issues:

      Description

      The HstFreeMarkerServlet provides a TagLibFactory instance which is saved and shared via the ServletContext between all requests.
      As this TagLibFactory is currently initialized during the first request, this can lead to race conditions if the servlet is hit by heavy concurrent initial usage (e.g. like with a benchmark).

      The TagLibFactory initialization however can just as well be done during the init phase of the servlet itself, which is synchronized by the container itself and thus no longer be subject to race conditions.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                adouma Ate Douma
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: