Uploaded image for project: 'Hippo Site Toolkit 2'
  1. Hippo Site Toolkit 2
  2. HSTTWO-3159

Backport: Getting canonical sitemap item explicitly might result in random one if multiple canonical sitemap items match

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.28.08
    • Component/s: None
    • Labels:
    • Similar issues:

      Description

      @QA : for reproduction:

      Start up testsuite, and then go to

      http://localhost:8080/site/restapi/news/2008/11/partner-event.html

      In there, the second link should be
      <link href="/site/news/2008/11/partner-event.html

      and not
      <link href="/site/news2/2008/11/partner-event.html
      or <link href="/site/news1/2008/11/partner-event.html

      Problem:

      In LocationMapResolver, there is #getCanonicalItem

      That method returns if there are multiple equally well suited canonical sitemap items (equal depth) the first canonicals.get(0);.

      Instead, it should just like the 'non explicit canonical link creation' use the LowestDepthFirstAndThenLexicalComparator

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                aschrijvers Ard Schrijvers
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: