Uploaded image for project: '[Read Only] - Hippo Site Toolkit 2'
  1. [Read Only] - Hippo Site Toolkit 2
  2. HSTTWO-2988

ObjectConverterImpl doesn't need to log warning: No Descriptor found for node '/'

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Trivial
    • Resolution: Fixed
    • 2.26.11, 2.28.02
    • 2.26.12, 2.28.03
    • None
    • None

    Description

      In my project, I see the following logs continuously:

      [INFO] [talledLocalContainer] 12.06.2014 16:57:03 WARN [org.hippoecm.hst.content.beans.manager.ObjectConverterImpl.getObject():177] No Descriptor found for node '/'. Cannot return a Bean for 'rep:root'.

      After debugging, I found that the warning log happens due to code from Selection forge module [1] like the following [2]:

      HippoBean virtualSiteContentBaseBean = hippoBean;
      while (!virtualSiteContentBaseBean.getPath().endsWith("hst:content")
      && (virtualSiteContentBaseBean.getParentBean() != null))

      { virtualSiteContentBaseBean = virtualSiteContentBaseBean.getParentBean(); }

      I think we can skip bean resolution if the target node is the root.
      This way, we can avoid this kind unnecessary warning logs.

      [1] http://selection.forge.onehippo.org/
      [2] https://forge.onehippo.org/svn/selection/selection/tags/selectionplugins-2.06.04/hst/src/main/java/org/onehippo/forge/selection/hst/manager/DefaultValueListManager.java

      Attachments

        Activity

          People

            jsheriff Junaidh Kadhar Sheriff
            wko Woonsan Ko (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: