Uploaded image for project: '[Read Only] - Hippo Site Toolkit 2'
  1. [Read Only] - Hippo Site Toolkit 2
  2. HSTTWO-2410

Abstract a AbstractPipelineTestCase out of TestDefaultPipeline so common logic can also be used by other test pipelines

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Normal
    • Resolution: Fixed
    • None
    • 2.26.01
    • None
    • None

    Description

      I want to add unit tests for page caching valve, and it reuses lots of the TestDefaultPipeline

      I also noticed that currently the innerclasses for NewsOverview, Header and DocumentTitle are not actually used during execution of the TestDefaultPipeline :

      Also code like below:

      HstComponent component = new NewsOverview();
      ((HstComponentFactoryImpl) componentFactory).componentRegistry.registerComponent(this.requestContainerConfig, "pages/newsoverview", component);

      perhaps worked in the past, but certainly not any more, as one and the same component can be inherited at many different locations, and hence the 'id' "pages/newsoverview" cannot be assumed at all.

      I also noticed removing the NewsOverview, Header and DocumentTitle does not influence the unit test in any way

      Attachments

        Issue Links

          Activity

            People

              svoortman Simon Voortman (Inactive)
              aschrijvers Ard Schrijvers
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: