Uploaded image for project: '[Read Only] - Hippo Site Toolkit 2'
  1. [Read Only] - Hippo Site Toolkit 2
  2. HSTTWO-1640

Error prone utilities: AbstractContentResource#getRequestContentNode() and #getRequestContentBean()

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: 2.20.03, 2.21.01, 2.22.01, 2.23.00
    • Fix Version/s: 2.23.01
    • Component/s: None
    • Labels:
      None
    • Similar issues:

      Description

      The two methods (AbstractContentResource#getRequestContentNode() and #getRequestContentBean()) are used often by JAX-RS Resource components.
      Currently the two utility methods depend on a Node object which is stored by CXFJaxrsContentService.
      Normally, this is no problem.
      However, if you change current content through CMS Workflow API via REST API, then the stored node will not be valid any more. The identifier can be changed and so the pre-stored node is invalid.
      Therefore, my suggestion would be to store the content node path only in CXFJaxrsContentService and the two utility method (AbstractContentResource#getRequestContentNode() and #getRequestContentBean()) should try to retrieve the content object by the path every time.
      This will reduce this kind of errors and time to find the problems.

        Attachments

          Activity

            People

            • Assignee:
              wko Woonsan Ko
              Reporter:
              wko Woonsan Ko
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: