Uploaded image for project: '[Read Only] - Hippo Site Toolkit 2'
  1. [Read Only] - Hippo Site Toolkit 2
  2. HSTTWO-1211

HstComponentConfiguration must use LinkedMap instead of SortedMap for getChildren();

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Top
    • Resolution: Fixed
    • 2.10.00
    • 2.10.01
    • None
    • None

    Description

      Currently we have the code and java docs below. However, the all usages of this 'getChildren' are meant to have a LinkedMap, not a SortedMap.

      As the it is used internally only, I want to change this for the 2.10. Are you ok with it? It is currently just wrong, and only used internally, hence, deprecating does not seem an option either to me

      HstComponentConfiguration.java

      /**

      • Implementations should return an unmodifiable sorted map, for example {@link java.util.Collections$UnmodifiableSortedMap}

        to avoid

      • client code changing configuration
      • @return all <code>HstComponentConfiguration</code> childrens, and an empty Map if no children present
        */
        SortedMap<String, HstComponentConfiguration> getChildren();

      Attachments

        Activity

          People

            aschrijvers Ard Schrijvers
            aschrijvers Ard Schrijvers
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: