Uploaded image for project: '[Read Only] - HST Configuration Editor'
  1. [Read Only] - HST Configuration Editor
  2. HSTCONFIGEDIT-154

Method HstContext.isDeleteAllowed calls equals with wrong parameter

    XMLWordPrintable

    Details

      Description

      Method HstContext.isDeleteAllowed calls equals with wrong parameter. The parameter type is HstModelContext, equals expects type JcrNodeModel.

      It is:
      public boolean isDeleteAllowed(JcrNodeModel model) {
      for (HstModelContext m : models) {
      if (model.equals(m))

      { return false; }
      }
      return true;
      }

      It should be:
      public boolean isDeleteAllowed(JcrNodeModel model) {
      for (HstModelContext m : models) {
      if (model.equals(m.getModel())) { return false; }

      }
      return true;
      }

      I attached patch with the fix.

        Attachments

          Activity

            People

            Assignee:
            meggermont Michiel Eggermont (Inactive)
            Reporter:
            gzur Grzegorz Zur (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: