Uploaded image for project: '[Read Only] - Hippo Plugins'
  1. [Read Only] - Hippo Plugins
  2. HIPPLUG-1633

Revisit org.hippoecm.editor.type.CompositeTypeDescriptor

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Normal
    • Resolution: Outdated
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: plugins-taxonomy
    • Labels:
      None
    • Similar issues:
    • Processed by team:
      Pulsar
    • Sprint:
      Platform 226 - Taxonomy 1, Platform 227 - Taxonomy 2

      Description

      In org.hippoecm.editor.type.AbstractJcrTypeStore#createTypeDescriptor a ITypeDescriptor is created from a nodetype. If that nodetype is extending another type, a descriptor for that super type is instead created. This is not necessarily correct cause any configuration on the parent type is ignored.

      In the case of taxonomy, nodetype /hippo:namespaces/system/taxonomyField/hipposysedit:nodetype/hipposysedit:nodetype defines property hipposysedit:plugin=true, but this is ignored because the type extends from String, which does not have that property.

      To solve this, a composite ITypeDescriptor was built. Please revisit this class given that:

      • Code used to use the 'PseudoTypeDescriptor'
      • That class needed revisiting because the ITypeDescriptor interface seems to handling supertypes already, see methods getFields versus getDeclaredFields

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                mchatzidakis Minos Chatzidakis
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: