Uploaded image for project: 'Hippo Plugins'
  1. Hippo Plugins
  2. HIPPLUG-1066

HST News Sitemap Component - does not parse propertyCriteria property correctly (patch attached)

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Top
    • Resolution: Fixed
    • Affects Version/s: sitemap-1.04.02
    • Fix Version/s: sitemap-1.04.03
    • Component/s: Sitemap.xml
    • Environment:
      Hippo CMS 7.8.9
      Hippo Forge Sitemap Protocol Component 1.04.02
    • Similar issues:
    • Story Points:
      0.5
    • Flagged:
      Flagged
    • Ticket type:
      Product (Warranty / HES)

      Description

      I am trying to use "propertyCriteria" property in sitemap for News Sitemap from Hippo Forge Sitemap Protocol Component[1]. Parameters that contains colon (:) symbol in parameter name can not be parsed - we get error message in the log "org.hippoecm.hst.core.component.HstComponentException: Criterion does not match pattern "property=condition" ".
      Parameter from documentation example[2] also does not work (hippostd:state=published).

      It seems that the problem is in org.onehippo.forge.sitemap.components.NewsSitemapFeed.java (line207) where regular expression for matching cafeterias is stored:

      Pattern propertyCriterionPattern = Pattern.compile("(\\w)\\s=\\s(\\w)"); [3]

      [1] http://sitemap.forge.onehippo.org/newssitemap.html
      [2] http://sitemap.forge.onehippo.org/newssitemap.html#Parameters
      [3] https://source.onehippo.com/browse/public/hippo-cms7/plugins/sitemap/trunk/component/src/main/java/org/onehippo/forge/sitemap/components/NewsSitemapFeed.java?r=47570#to207

        Attachments

        1. sitemap-1.04.xx.patch
          0.9 kB
        2. sitemap-1.06.xx.patch
          0.9 kB
        3. sitemap-trunk.patch
          0.9 kB

          Issue Links

            Activity

              People

              • Assignee:
                jhoffman Jeroen Hoffman
                Reporter:
                u-roma Roman Uholnikov
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - 2 hours
                  2h
                  Remaining:
                  Remaining Estimate - 2 hours
                  2h
                  Logged:
                  Time Spent - Not Specified
                  Not Specified