[Document Commenting] Categorize doccommentdata's child nodes as system

Davey Chu reported this with a solution in PR:

• https://github.com/onehippo-forge/document-commenting/pull/1

We are migrating from Hippo 11 to 12 and have used the Document Commenting Plugin for quite some time. The doccommentdata node’s children seem to contain the current comments. As far as I can tell, the latest (3.0.0) version of the plug-in does not explicitly categorize child-nodes (through .meta:residual-child-node-category) so they default to config. This results in the doccommentdata being wiped out (as the Configuration Verifier correctly detects).

I have made a pull request that categorizes the child nodes as content. If they are better categorized as system, I’ll gladly change it. For my own understanding, I would appreciate it if you could explain your reasoning for one or the other category.

Woonsan confirmed his finding and solution:

Thanks again! You’re totally right. Would you change it to “system”? Then I will merge it and cut a new release very soon.

The /doccommentdata node is the comment data storage folder, similarly to HST Form Data storage [2,3]. And HST also sets it to “system”. [4]

[2] https://www.onehippo.org/library/concepts/component-development/hst-2-forms.html
[3] https://www.onehippo.org/library/administration/maintenance/form-data-cleanup.html
[4] https://code.onehippo.org/cms-community/hippo-site-toolkit/blob/hst-5.4.0/toolkit-resources/addon/repository/src/main/resources/hcm-config/formdata.yaml#L4