Details
-
Bug
-
Status: Closed
-
Normal
-
Resolution: Fixed
-
None
-
None
-
Flagged
-
Turing Sprint 121, Turing Sprint 122
-
Support (Billable)
Description
There is a small bug in CMS7-9194. The whitespace between two paragraphs is only 0.3em, while looking at the changed CSS lines the intention is to change it into 1em, but due to a small mistake this is not the case.
I see in CMS7-9194 that the following lines are added to the stylesheet:
121 .cke_wysiwyg_div.cke_editable h1, 122 .cke_wysiwyg_div.cke_editable h2, 123 .cke_wysiwyg_div.cke_editable h3, 124 .cke_wysiwyg_div.cke_editable h4, 125 .cke_wysiwyg_div.cke_editable h5, 126 .cke_wysiwyg_div.cke_editable h6, 127 .cke_wysiwyg_div.cke_editable p { 128 margin-top: 0.7em; 129 margin-bottom: 0.3em; 130 }
and also
132 .cke_wysiwyg_div.cke_editable h1:first-child, 133 .cke_wysiwyg_div.cke_editable h2:first-child, 134 .cke_wysiwyg_div.cke_editable h3:first-child, 135 .cke_wysiwyg_div.cke_editable h4:first-child, 136 .cke_wysiwyg_div.cke_editable h5:first-child, 137 .cke_wysiwyg_div.cke_editable h6:first-child, 138 .cke_wysiwyg_div.cke_editable p { 139 margin-top: 0; 140 }
The last line with margin-top: 0; overwrites the margin-top: 0.7em for the .cke_wysiwyg_div.cke_editable p tag. This results in .cke_wysiwyg_div.cke_editable p only having a margin-bottom: 0.3em.. The margin-top: 0.7em; for the .cke_wysiwyg_div.cke_editable p tag is always overwritten, so this cannot be correct.
The last selector should contain .cke_wysiwyg_div.cke_editable p:first-child (so with :first-child added).
Attachments
Issue Links
- is a forward port of
-
CMS-9496 Not enough whitespace in text editor (with patch)
- Closed