Uploaded image for project: 'Hippo CMS'
  1. Hippo CMS
  2. CMS-9413

SASS: computed-line-height changed

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Normal
    • Resolution: Won't Fix
    • None
    • None
    • None
    • None

    Description

      I compared the output of the new hippo-cms-theme.css with the old one and found one difference that has visual impact: the $line-height-computed variable is changed from 15px to 16px which leads to the following rules being changed:

      .hippo-list-documents > thead > tr > th {
      line-height: 15px; -> line-height: 16px;
      padding-top: 13px; -> padding-top: 12px;
      }

      .hippo-tabs-documents ul > li > div .hippo-tabs-documents-tab span {
      line-height: 15px; -> line-height: 16px;
      }

      .hippo-list-documents > tbody > tr > td:not(.doclisting-icon) > span span {
      line-height: 30px; -> line-height: 32px;
      }

      .alert {
      margin-bottom: 15px; -> margin-bottom: 16px;
      }

      I noticed that HippoTheme defines $line-height-base: 1.24; where HippoCMS defines $line-height-base: 1.2

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              abogaart Arthur Bogaart
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: