Uploaded image for project: 'Hippo CMS'
  1. Hippo CMS
  2. CMS-9309

Improve code to use IEditor.Mode enum

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Normal
    • Resolution: Fixed
    • 2.28.01
    • 2.28.02
    • None
    • Tiger Sprint 106

    Description

      There are quite many classes that retrieves "mode" parameter from the plugin config as String value and identify mode values as String values, i.e. use string comparison. It can be found by search the following pattern for all java file:

      config.getString("mode"

      It'd better to use IEditor.Mode enum with #fromString() method rather than such string comparison.

      Attachments

        Issue Links

          causes

          Bug - A problem which impairs or prevents the functions of the product. CMS-9376 Regression:Crop Image & Restore button not displayed while trying to edit an image

          • Blocker - Blocks further development for most developers or blocks intermediate release
          • Closed
          discovered while testing

          Bug - A problem which impairs or prevents the functions of the product. CMS-9154 RuntimeException if updating assets/images larger than the max.file.size setting

          • Top - Should be worked on at this time and be top on the list, required for next intermediate release
          • Closed

          Activity

            People

              Unassigned Unassigned
              cngo Canh Ngo (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: