Details
-
Bug
-
Status: Closed
-
High
-
Resolution: Fixed
-
None
-
None
Description
HtmlCleaner kicks in twice and even with different cleaner configuration
As a result of CMS7-1610, the html cleaner also kicks in in org.hippoecm.frontend.plugins.richtext.jcr.ChildFacetUuidsModel. Imo, the ChildFacetUuidsModel doesn't imply any text clean up, or text manipulation that the html cleaner does (like replacing html encoding with UTF-8 encoding)
It is most likely possible to 'fix' the problem by using the same HtmlCleaner configuration as the HtmlCleanerPlugin does. Downside is the html cleaner still kicks in twice. Imo undesirable. Not sure whether it is easy to fix.
The ChildFacetUuidsModelTest should also get added unit tests with html encoded chars
( & g t ; , & l t ; ) and chars like
(d & e a c u t e ; m o versus démo)
(note above I have spaces in the encoded words otherwise you don't see it in jira html mode)
Note I bumped this one to blocker since when this issue does not get addressed, not xml formatted text can be added any more, for example in onehippo.org, we very frequently use something like (ps use & l g ; instead of <. Look in the edit mode description of this jira issue to see what you need to copy paste):
EXAMPLE:
<pre class="sh_xml"><hst:defineObjects/>
<c:set var="isPreview" value="${hstRequest.requestContext.preview}"/>
</pre>
This now gets removed by the cleaner it seems...or even worse, it seems to silently fail (!!) and removes all your changes (!!).
Attachments
Issue Links
- causes
-
CMS-8638 Consolidate and merge functionality of the RichTextModel and ChildFacetUuidsModel
- Closed
- is a result of
-
CMS-1610 Wrong image shown in html editor when two images have the same name
- Closed
- is backported by
-
CMS-8713 Backport 8616 to 7.9: Cannot type and save > any more in ckeditor because becomes >
- Closed
- relates to
-
CMS-8610 CKEditor stores accented characters not as UTF-8
- Closed
-
CMS-8628 Backport 8610 to 79 - CKEditor stores accented characters not as UTF-8
- Closed
-
CMS-8618 When RichTextModel HtmlCleaner fails, a silent fail happens and all changes are lost
- Closed
-
CMS-8620 HtmlCleanerPlugin can result in NPE in #filter
- Closed