Uploaded image for project: 'Hippo CMS'
  1. Hippo CMS
  2. CMS-8432

Image variants with same dimensions as original are skipped from scaling, missing out on compression/optimization

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: 2.24.14, 2.26.10, 2.28.00
    • Fix Version/s: 2.24.16
    • Component/s: None
    • Similar issues:
    • Flagged:
      Flagged

      Description

      Image variants that have the same width&height as the original image are skipped in the ScaleImageOperation, missing out on possible compression/optimization settings.

      See line 284 in class ScaleImageOperation:

      if (resizeRatio == 1.0d || (resizeRatio >= 1.0d && !upscaling)) {

      Could be replaced with

      if (resizeRatio > 1.0d && !upscaling) {

      This will lead to a slight drop in overall performance, but only for images that have exactly the same dimensions as the original, so not very important.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                abogaart Arthur Bogaart
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: