Uploaded image for project: 'Hippo CMS'
  1. Hippo CMS
  2. CMS-8432

Image variants with same dimensions as original are skipped from scaling, missing out on compression/optimization

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Normal
    • Resolution: Fixed
    • 2.24.14, 2.26.10, 2.28.00
    • 2.24.16
    • None
    • Flagged

    Description

      Image variants that have the same width&height as the original image are skipped in the ScaleImageOperation, missing out on possible compression/optimization settings.

      See line 284 in class ScaleImageOperation:

      if (resizeRatio == 1.0d || (resizeRatio >= 1.0d && !upscaling)) {

      Could be replaced with

      if (resizeRatio > 1.0d && !upscaling) {

      This will lead to a slight drop in overall performance, but only for images that have exactly the same dimensions as the original, so not very important.

      Attachments

        Issue Links

          causes

          Bug - A problem which impairs or prevents the functions of the product. CMS-9335 Regression: original image data is no longer stored as-is

          • Blocker - Blocks further development for most developers or blocks intermediate release
          • Closed
          is forward ported by

          Improvement - An improvement or enhancement to an existing feature or task. CMS-8666 Forward port to 7.9: Image variants with same dimensions as original are skipped from scaling, missing out on compression/optimization

          • Normal - Normal priority, tasks to be done before next intermediate release
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. CMS-8667 Forward port to 7.10: Image variants with same dimensions as original are skipped from scaling, missing out on compression/optimization

          • Normal - Normal priority, tasks to be done before next intermediate release
          • Closed

          Activity

            People

              Unassigned Unassigned
              abogaart Arthur Bogaart
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: