Uploaded image for project: 'Hippo CMS'
  1. Hippo CMS
  2. CMS-7223

Changes notification not visible for authors; it's incorrectly placed

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Normal
    • Resolution: Fixed
    • None
    • 2.26.00-alpha-1, 2.26.00
    • None

    Description

      In CMS7-7214 I did the following :

      instead of separately fetching the users who have changes over a rest call, just use the channel store itself as this contains that info. Also remove the changedBySet from PageContext as it is not added as header any more by the HST.
      Also, for an author, just show who have changes in the channel. Only problem still remaining is that for some reason, the 'showChannelNotification' does not show the yellow bar for authors in the right place (it is actually not visible due not being located below the toolbar but more above behind some other divs)

      For some reason, when the code block below is executed for an author, the yellow bar is not visible as not correctly located below the toolbar (it gets shown but in the top behind other stuff).... (before when an exception happened via the rest calls for an author it would be visible....so strange)

      showChannelChangesNotification: function(pageContext) {
      var notification, userIds;
      notification = Ext.getCmp('channelChangesNotification');
      if (pageContext.fineGrainedLocking) {
      if (this.channel.changedBySet.length === 0)

      { notification.hide(); }

      else

      { // don't reorder the changedBySet, hence first clone it userIds = this.channel.changedBySet.slice(0); moveFirstIfExists(userIds, this.cmsUser); notification.setMessage(createChangesForUsersNotificationMessage(userIds, this.cmsUser, this.resources)); notification.show(); }

      } else

      { notification.setMessage(this.resources['previous-live-msg']); notification.show(); }

      },

      Attachments

        Issue Links

          Activity

            People

              jsheriff Junaidh Kadhar Sheriff
              aschrijvers Ard Schrijvers
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: