Uploaded image for project: 'Hippo CMS'
  1. Hippo CMS
  2. CMS-6826

EditingReviewedActionsWorkflowPlugin is not extension-friendly

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Normal
    • Resolution: Outdated
    • 2.22.13
    • None
    • addon-reviewed-actions
    • Hippo CMS 7.7.7

    Description

      The workflow frontend plugin org.hippoecm.frontend.plugins.reviewedactions.EditingReviewedActionsWorkflowPlugin
      contains two methods (validate() and isValid()) which have default visibility:

      void validate() throws ValidationException {
      isValid = true;
      List<IValidationService> validators = getPluginContext().getServices(
      getPluginConfig().getString(IValidationService.VALIDATE_ID), IValidationService.class);
      if (validators != null) {
      for (IValidationService validator : validators)

      { validator.validate(); IValidationResult result = validator.getValidationResult(); isValid = isValid && result.isValid(); }

      }
      }

      boolean isValid()

      { return isValid; }

      When extending EditingReviewedActionsWorkflowPlugin (for example to add an additional button in the editing menu), the above two methods are not visible to the extending class and must be duplicated locally.

      If the methods had 'protected' visibility this would not be necessary.

      Attachments

        Activity

          People

            swesten Stephan Westen
            nvankampenhout Niels van Kampenhout
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: