Uploaded image for project: 'Hippo CMS'
  1. Hippo CMS
  2. CMS-3913

Check if UpdaterItemVisitor does correct check for if node is virtual or not

    XMLWordPrintable

Details

    • Task
    • Status: Closed
    • Normal
    • Resolution: Fixed
    • None
    • r2.12.07, r2.13.00
    • None
    • None

    Description

      In UpdaterItemVisitor there is this logic:

      public void visit(Node node) throws RepositoryException {

      if(node instanceof HippoNode) {
      Node canonical = ((HippoNode) node).getCanonicalNode();
      if(canonical == null || canonical.isSame(node))

      { return; }

      }

      It seems to me, that this tries to skip virtual node. But, I think the part

      canonical.isSame(node)

      must be

      !canonical.isSame(node)

      We need to check this

      Attachments

        Activity

          People

            spelissier Sylvain PĂ©lissier (Inactive)
            aschrijvers Ard Schrijvers
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: