Uploaded image for project: 'Hippo CMS'
  1. Hippo CMS
  2. CMS-16014

Remove protobuf-java from dependency tree

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Normal
    • Resolution: Fixed
    • None
    • 14.7.22, 15.7.0, 16.1.0
    • None
    • None

    Description

      On several occurrences, there's an exclusion/addition pattern regarding protobuf-java that is a dependency of mysql-connector-java:

          <dependency>
            <groupId>com.mysql</groupId>
            <artifactId>mysql-connector-j</artifactId>
            <exclusions>
              <exclusion>
                <groupId>com.google.protobuf</groupId>
                <artifactId>protobuf-java</artifactId>
              </exclusion>
            </exclusions>
          </dependency>
          <dependency>
            <groupId>com.google.protobuf</groupId>
            <artifactId>protobuf-java</artifactId>
            <version>3.21.12</version>
          </dependency>
          <dependency>
      

      The mysql-connector-j has 'test' scope, now this pattern wrongly pulls in protobuf-java with 'compile' scope.

      Moreover, the README at https://github.com/mysql/mysql-connector-j says that we can exclude protobuf-java altogether if we do not use the X DevAPI features, which we don't.

      This matches the fact that we tell clients to provide mysql-connector-j but never protobuf-java.

      Attachments

        Activity

          People

            jhoffman Jeroen Hoffman
            jhoffman Jeroen Hoffman
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: