Uploaded image for project: 'Hippo CMS'
  1. Hippo CMS
  2. CMS-14927

Regression: component icons have fully qualified URLs

    XMLWordPrintable

Details

    • Flagged
    • Quasar
    • Team Quasar sprint 278, Quasar sprint 279

    Description

      Since 14.6.3, component icons in the Channel Manager are rendered with fully qualified URLs instead of relative URLs. This seems unintended and causes problems in case the CMS host is different than the site host.

      In org.hippoecm.hst.pagecomposer.jaxrs.model.ComponentRepresentation#represent there's this piece of code

      if (StringUtils.isNotBlank(iconPath)) {
          HstRequestContext requestContext = RequestContextProvider.get();
          iconURL = requestContext.getHstLinkCreator().create(iconPath, mount, true).toUrlForm(requestContext, false);
      }
      

      Note, the last "false" is a fullyQualified flag.

      On a local 14.6.2 archetype-based project, this is a relative URL, e.g.
      /site/images/essentials/catalog-component-icons/simple-content.svg

      On a local 14.6.3 archetype-based project, this is a fully qualified URL, e.g.
      http://localhost:8080/site/images/essentials/catalog-component-icons/simple-content.svg

      I suspect CMS-14805 to be the cause.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              jhoffman Jeroen Hoffman
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: