Uploaded image for project: 'Hippo CMS'
  1. Hippo CMS
  2. CMS-14875

HST Diagnostics: WARN pollution by DefaultTaskImpl

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Normal
    • Resolution: Fixed
    • 14.6.3
    • 14.7.4, 15.0.0
    • None
    • Flagged
    • DXP Solutions

    Description

      Since CMS-11514 on 13.0.0, org.hippoecm.hst.diagnosis.Task extends AutoCloseable, so explicit calls to #stop are no longer needed/expected.

      Causes log pollution
      However, org.hippoecm.hst.diagnosis.DefaultTaskImpl logs warnings when already stopped, and there are still 70+ explicit calls to this method in finally blocks, leading to WARNs being logged for no reason.

          public void stop() {
              if (stopped) {
                  log.warn("Task '{}' was already stopped.", name);
                  return;
              }
        .....
      

      Proposed fix
      Either remove the warning, or remove the explicit calls

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              jhoffman Jeroen Hoffman
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: