Uploaded image for project: 'Hippo CMS'
  1. Hippo CMS
  2. CMS-14289

Throttle logging of hst components rendering waste

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Normal
    • Resolution: Fixed
    • None
    • 14.5.0
    • None
    • None
    • 0.25
    • Quasar
    • Puma Sprint 250

    Description

      Pursuant to HSTTWO-3700, logging for hst components rendering waste was reintroduced but given a boolean option to suppress output of the messages (and the WARN-level messages do clearly provide this detail to the developer).

      Since the reintroduction however, it has been fairly commonplace to see massive daily logging as a result. Although it's often trivial to set the boolean in the console, in practice, particularly where large numbers of offending components are involved, this is only carried out with reluctance. This is especially the case in newer installations where the logs need to be read for many other issues.

      A single global setting or means of throttling the frequency of these messages would be worthwhile.

      In sum, excessive logging:
      1. Impairs the ability to troubleshoot the application;
      2. May cause an I/O performance hit in the presence of other excessive logging;
      3. Threatens resource consumption.

      Production sample where it is the 2nd highest warning logged:

      ./analyzelog.sh hippo-site.log.2020-12-02
      ****************************************************************************
      ************************ Most common errors ********************************
          284 [com.[].services.integration.message.LineItemMessageMappingServiceImpl.setProductUrl():188]
           86 [com.[].services.integration.message.ListrakImpl.subscribeCustomer():232]
           20 [com.[].services.api.rest.ServicesUtils.loggingHandling():61]
           15 [com.[].commercetools.CommerceToolsDAO.getIdForNextQuery():297]
      ************************ Most common causes ********************************
      ************************ Most common warnings ******************************
       363675 [org.hippoecm.hst.configuration.components.HstComponentConfigurationService.setRenderPath():1045]
        10180 [org.hippoecm.hst.core.container.AggregationValve.logPossibleWaste():586]
         3588 [org.hippoecm.hst.configuration.components.HstComponentsConfigurationService$Template.<init>():360]
         1554 [org.hippoecm.hst.servlet.BinariesServlet.copyPageToResponse():422]
          633 [org.hippoecm.hst.configuration.components.HstComponentConfigurationService.getReferencedContainer():466]
          601 [org.hippoecm.hst.core.container.NotFoundValve.invoke():43]
          510 [org.hippoecm.hst.core.hosting.CustomMountAndVirtualCmsHostAugmenter.addCmsLocationToHostGroup():173]
          184 [org.hippoecm.hst.configuration.components.HstComponentConfigurationService.<init>():251]
           53 [org.hippoecm.hst.container.HstDelegateeFilterBean.doFilter():210]
            1 [org.hippoecm.hst.core.container.CmsSecurityValve.invoke():193]
            1 [org.hippoecm.hst.core.container.CmsSecurityValve.invoke():177]
      

      Attachments

        Activity

          People

            jcopson Jay Copson
            jcopson Jay Copson
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: