Uploaded image for project: 'Hippo CMS'
  1. Hippo CMS
  2. CMS-12339

Cannot copy or move documents in a hippostd:directory folder

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 13.3.2, 13.4.1, 14.0.0
    • Component/s: None
    • Labels:
      None

      Description

      in CMS-11876 a check has been introducded:

      if (wdm != null) {
           Node node = getHandleOrUnpublishedVariant(wdm.getWorkflow());
            Validate.isTrue(node.isNodeType(HippoNodeType.NT_HANDLE));
            folderModel = new JcrNodeModel(node.getParent());
          Validate.isTrue(folderModel.getNode().isNodeType(HippoStdNodeType.NT_FOLDER));
       }
      

      First of all, we shouldn't use Validate.isTrue in production code. It just throws an IllegalArgExc leaving the UI broken. We need to handle corner cases. Apart from that, next to HippoStdNodeType.NT_FOLDER we als have hippostd:directory which is now broken.

      I suggest to remove the Validate.isTrue altogether: it is AbstractDocumentWorkflowPlugin ....what else can it be than the handle and the parent a folder?

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              aschrijvers Ard Schrijvers
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: