Uploaded image for project: 'Hippo CMS'
  1. Hippo CMS
  2. CMS-11994

Make locale and timezone cookies HttpOnly

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Normal
    • Resolution: Fixed
    • 13.3.0
    • 13.3.0
    • None
    • None

    Description

      The cookies for local and timezone are managed and used by the LoginPanel, there is no functional need for them to be read by javascript, so we should mark them HttpOnly.

      The usage-statistics script still tries to read the locale cookie in case it is not provided with the 'start-usage-statistics' event, which is only true for CMS < 11.2.

      I did not find any other pieces of javascript that rely on these cookies. And if there is still a need to know these values from javascript, there is a much simpler way with these two global vars:

      window.Hippo.Session.locale
      window.Hippo.Session.timezone
      

      Attachments

        Activity

          People

            Unassigned Unassigned
            abogaart Arthur Bogaart
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: