Uploaded image for project: 'Hippo CMS'
  1. Hippo CMS
  2. CMS-11866

Add a possibility to use auto and initial in setHeight calls

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: 13.2.0
    • Fix Version/s: 13.2.0
    • Component/s: None
    • Labels:
      None
    • Epic Link:
    • Processed by team:
      Tiger
    • Sprint:
      Tiger Sprint 206, Tiger Sprint 207

      Description

      In order to make `setHeight` consistent with CSS `height` property, it's better to add support of 'auto' and 'initial' values as arguments in `setHeight`.

      Requirements:

      • `setHeight('auto')` - enables auto height adjustment;
      • `setHeight('initial')` - sets initial iframe height taken from the configuration (and disables automatic mode);
      • `setHeight(<pixels>)` - sets custom iframe height (and disables automatic mode);
      • add resize event listener in automatic mode to react correctly on image loading events;
      • possibly remove `updateHeight` public method since the problem with images is fixed by the resize event.
      • remove `autoUpdateHeight` public method since it's possible to pass `auto` into `setHeight`.

        Attachments

          Activity

            People

            Assignee:
            Unassigned Unassigned
            Reporter:
            mdokolin Mikhail Dokolin (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: