Uploaded image for project: 'Hippo CMS'
  1. Hippo CMS
  2. CMS-10052

[Backport 3.2.2] Make AbstractFieldPlugin.onAddRenderService() non-final

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: 3.2.1
    • Fix Version/s: 3.2.2
    • Component/s: None
    • Labels:
      None
    • Similar issues:
    • Story Points:
      0
    • Processed by team:
      Platform
    • Sprint:
      Platform sprint 128

      Description

      I need to extend some field plugins so that in edit mode, they sometimes only get view controls and not edit controls (when it does that is to be decided dynamically). To achieve that, I'd like to override

      org.hippoecm.frontend.editor.plugins.field.AbstractFieldPlugin.onAddRenderService(Item<IRenderService>, IRenderService)

      but it is declared final for some reason. To my knowledge, this should be a binary compatible change.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                aschrijvers Ard Schrijvers
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - 5 minutes
                  5m
                  Remaining:
                  Remaining Estimate - 5 minutes
                  5m
                  Logged:
                  Time Spent - Not Specified
                  Not Specified