Uploaded image for project: 'Addon Channel Manager'
  1. Addon Channel Manager
  2. CHANNELMGR-2250

hippo-addon-channel-manager-repository artifact pulls in CMS and wicket jars

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 13.0.1, 13.1.0
    • Labels:
      None
    • Similar issues:
    • Processed by team:
      Platform
    • Sprint:
      Platform 202 - HST Hosts & BRC

      Description

      hippo-addon-channel-manager-repository has a dependency on:

      <dependency>
            <groupId>org.onehippo.cms7</groupId>
            <artifactId>hippo-addon-channel-manager-content-service</artifactId>
            <version>${project.version}</version>
          </dependency>
      

      This is bad, since hippo-addon-channel-manager-content-service pulls in a lot of wicket code, which is not ok since for platform + site deployment we pull in hippo-addon-channel-manager-repository

      Instead, move the yaml config from hippo-addon-channel-manager-content-service to the repository module, and let hippo-addon-channel-manager-frontend-ng transitively pull in hippo-addon-channel-manager-content-service

      Next to that, channel-content-service-module.yaml its ChannelContentServiceModule should be marked to only run in cms, thus

      cmsOnly : true
      

      Namely it fails for downstream projects in case of repository + site deployments

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              aschrijvers Ard Schrijvers
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: