Uploaded image for project: '[Read Only] - Addon Channel Manager'
  1. [Read Only] - Addon Channel Manager
  2. CHANNELMGR-2250

hippo-addon-channel-manager-repository artifact pulls in CMS and wicket jars

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Normal
    • Resolution: Fixed
    • None
    • 13.0.1, 13.1.0
    • None

    Description

      hippo-addon-channel-manager-repository has a dependency on:

      <dependency>
            <groupId>org.onehippo.cms7</groupId>
            <artifactId>hippo-addon-channel-manager-content-service</artifactId>
            <version>${project.version}</version>
          </dependency>
      

      This is bad, since hippo-addon-channel-manager-content-service pulls in a lot of wicket code, which is not ok since for platform + site deployment we pull in hippo-addon-channel-manager-repository

      Instead, move the yaml config from hippo-addon-channel-manager-content-service to the repository module, and let hippo-addon-channel-manager-frontend-ng transitively pull in hippo-addon-channel-manager-content-service

      Next to that, channel-content-service-module.yaml its ChannelContentServiceModule should be marked to only run in cms, thus

      cmsOnly : true
      

      Namely it fails for downstream projects in case of repository + site deployments

      Attachments

        Activity

          People

            Unassigned Unassigned
            aschrijvers Ard Schrijvers
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: