Uploaded image for project: '[Read Only] - Addon Channel Manager'
  1. [Read Only] - Addon Channel Manager
  2. CHANNELMGR-2241

Improve error handling for HST services calls like ChannelService#getPreviewChannels throws

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Top
    • Resolution: Fixed
    • None
    • 13.0.0
    • None
    • Platform 197 - Workshop+

    Description

      Currently, there is code in for example the ChannelStore as follows:

      try {
            return getChannelService().getChannelResourceValues(getHostGroup(), channel.getId(), locale);
            } catch (IllegalStateException e) {
                log.info("Cannot get channel resources: {}", e.getMessage());
                return new Properties();
            }
      

      This is problematic. First of all, end projects can hook in custom channel filters which can throw any runtime exception which is not caught unless it is an IllegalStateException. Such exceptions then bubble all the way up and are handled by wicket, resulting in long stacktraces and a channel mngr dashboard which does not respond when clicking on it. And equally bad, when an IllegalStateException you get an empty channel mgr overview but nothing will be logged (unless ChannelStore is at info log level which is unlikely and developers can't know)

      Better to always log a warning

      Attachments

        Activity

          People

            Unassigned Unassigned
            aschrijvers Ard Schrijvers
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: