Uploaded image for project: '[Read Only] - Addon Channel Manager'
  1. [Read Only] - Addon Channel Manager
  2. CHANNELMGR-2188

Internal links in Channel Mngr open in new dialog

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Blocker
    • Resolution: Fixed
    • None
    • 13.0.0
    • None
    • 2
    • Tiger Sprint 195 - Hardening

    Description

      The 'contextPaths' logic in the channel mgr is not usable any more, let alone the default

       this.contextPaths = ['/site'];
      

      logic. As a result, linkProcessor.service.js opens links in the channel mgr as a new tab in case the webapp is not site.war (which in general it is never any more)

      The logic would be better in linkProcessor.service.js to just handle links starting with '/' as internal links, and if the link is fully qualified as an external link...I don't think the hst links in the channel mgr are ever fully qualified. We could also check that if the link is a fully qualified link (incl http(s) ), to treat the link as internal if it uses the same scheme and host as the cms (since all hst links go via the cms host in channel mgr). As said, I also think it could just be enough to treat any link starting with http(s) as external and the rest as internal

      Apart from this, we should cleanup the code to not use 'internalLinkPrefixes' and 'contextPaths' any more : Not needed any more

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              aschrijvers Ard Schrijvers
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: