Uploaded image for project: '[Read Only] - Addon Channel Manager'
  1. [Read Only] - Addon Channel Manager
  2. CHANNELMGR-1827

Better detection of RequireJS signature

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Normal
    • Resolution: Fixed
    • 4.2.5
    • 5.4.0
    • None

    Description

      Since CHANNELMGR-1270 and 11.2 back port CHANNELMGR-1530 the Channel Manager does a check for RequireJS having been loaded by a site implementation. It does that by checking a "require" object on the window.

      When a client has a "require" object that is not RequireJS, the Channel Manager stops working because dragula.js is not loaded.

      Let's make the detection for RequireJS more specific, for instance by checking the number of arguments or (better yet) some internal property.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              jhoffman Jeroen Hoffman
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: