Uploaded image for project: '[Read Only] - Hippo Repository'
  1. [Read Only] - Hippo Repository
  2. REPO-2217

Class instances other than SessionImplHelper should never keep a AuthorizationQuery reference themselves

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Normal
    • Resolution: Fixed
    • None
    • 14.0.0
    • None
    • None

    Description

      See for example REPO-1429 : in there, we added support for the

      org.hippoecm.repository.jackrabbit.SessionImplHelper#getAuthorizationQuery
      

      to be able to return a new updated authorization query in case new nodetypes were added. The same we need also now in case the 'implicit reads' change : That results in a different authorization query as well. This is not so hard to implement.

      However, I stumbled upon

      org.hippoecm.repository.FacetedNavigationEngineImpl.ContextImpl 
      

      which stores the AuthorizationQuery in a private instance variable, which will never get updated.

      private AuthorizationQuery authorizationQuery;
      

      that is not allowed. It should always get the authorization query again via the session such that an updated version can be returned

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              aschrijvers Ard Schrijvers
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: